Skip to content

documenting the custom schemes handling#357

Open
boynet wants to merge 2 commits into
apache:masterfrom
boynet:master
Open

documenting the custom schemes handling#357
boynet wants to merge 2 commits into
apache:masterfrom
boynet:master

Conversation

@boynet

@boynet boynet commented Nov 28, 2018

Copy link
Copy Markdown

Platforms affected

android, ios

What does this PR do?

documenting the custom schemes handling(#263 and #274)

need to wait for #274 to get merged

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Comment thread README.md Outdated
Co-Authored-By: boynet <1615629+boynet@users.noreply.github.com>
@boynet

boynet commented Nov 28, 2018

Copy link
Copy Markdown
Author

some things I am not sure about:

  • should the preference part move into the Installation step?
  • should I give real world example like facebook\twitter\whatsapp or keep the "examplescheme"
  • the ios pr CB-14187: (ios) Change the InAppBrowser to allow custom schemes #274 not merged yet so we need for it to get merged in order to accept this, or just state that its for android only

@janpio

janpio commented Nov 28, 2018

Copy link
Copy Markdown
Member

Best let's wait that #274 gets merged. (Mention it in the description of the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants